#36633: TaskBackend run_after validation assumes datetime when USE_TZ=True
---------------------------------+--------------------------------------
     Reporter:  Chris M          |                    Owner:  (none)
         Type:  Bug              |                   Status:  closed
    Component:  Tasks            |                  Version:  6.0
     Severity:  Release blocker  |               Resolution:  wontfix
     Keywords:                   |             Triage Stage:  Unreviewed
    Has patch:  0                |      Needs documentation:  0
  Needs tests:  0                |  Patch needs improvement:  0
Easy pickings:  0                |                    UI/UX:  0
---------------------------------+--------------------------------------
Comment (by Chris M):

 Thanks for the context. I figured there was probably a conversation about
 the `timedelta` that I was just missing. Personally, I think it is more
 confusing to have the time be static, when the transaction close time is
 dynamic, but I understand needing to make a call and go with it, not a
 problem.

 If you are open to it, Jake, I'm happy to cut a PR against `django-tasks`
 for the type check before the timezone aware check. You are correct that
 it is failing, which is the final outcome either way. However, as a
 developer interacting with it, I was confused about what steps I should
 take, since the error had less to do with making the value timezone aware
 and more that I just passed in the wrong type completely. I think the
 clean up here could create a better developer experience.
-- 
Ticket URL: <https://code.djangoproject.com/ticket/36633#comment:5>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To view this discussion visit 
https://groups.google.com/d/msgid/django-updates/01070199ab3674b8-7f60b1a2-0bfa-4f07-972b-3a07e515bb8f-000000%40eu-central-1.amazonses.com.

Reply via email to