#36708: `formset` not a static attribute of `ChangeList`
-------------------------------------+-------------------------------------
Reporter: Ben Gregory | Owner: Rudraksha
Type: | Dwivedi
Cleanup/optimization | Status: assigned
Component: contrib.admin | Version: dev
Severity: Normal | Resolution:
Keywords: ChangeList | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 1
Easy pickings: 1 | UI/UX: 0
-------------------------------------+-------------------------------------
Comment (by Rudraksha Dwivedi):
Replying to [comment:8 Antoliny]:
> Replying to [comment:7 Rudraksha Dwivedi]:
> > can someone shed some light on the flake8 test on the automated github
testing flow ?
> > i think the issue is solved but some linting test fail
> > so i am not setting needs improvement to no currently
> > thank you!
>
> Would you like to refer to this
[https://docs.djangoproject.com/en/5.2/internals/contributing/writing-code
/unit-tests/#running-tests-using-to document]?
>
> You can run the tests with tox as well, but if you use pre-commit, lint
tests will run automatically when you make a commit!
hey thanks for your response!!
i read through the article and your suggestion about about precommit lint
test was really helpful
however due to some odd reason even after running the precommit test
with relevant test log = (
black....................................................................Passed
blacken-docs.........................................(no files to
check)Skipped
isort....................................................................Passed
flake8...................................................................Passed
eslint...............................................(no files to
check)Skipped
[ticket-36708 e877e5a3be] Cleanup for flake8 check
1 file changed, 1 insertion(+), 1 deletion(-)
)
to me it looked like its done but after pushing the GitHub automated flow
showed same issue can i get some more cues on what i can do ?
also, unrelated question is committing + pushing to the PR so many times
(to fix the issue of this nature where u can only see the result on
pushing) considered a bad practise ?
thanks !
--
Ticket URL: <https://code.djangoproject.com/ticket/36708#comment:9>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
--
You received this message because you are subscribed to the Google Groups
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To view this discussion visit
https://groups.google.com/d/msgid/django-updates/0107019a97d73ba2-e58fe942-94c2-4d20-b651-b720645f0645-000000%40eu-central-1.amazonses.com.
