#36708: `formset` not a static attribute of `ChangeList`
-------------------------------------+-------------------------------------
Reporter: Ben Gregory | Owner: Rudraksha
Type: | Dwivedi
Cleanup/optimization | Status: assigned
Component: contrib.admin | Version: dev
Severity: Normal | Resolution:
Keywords: ChangeList | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 1
Easy pickings: 1 | UI/UX: 0
-------------------------------------+-------------------------------------
Comment (by Rudraksha Dwivedi):
Replying to [comment:10 Antoliny]:
> Running only flake8 locally through tox is also an option.
>
> {{{
> tox -e flake8
> }}}
>
> Replying to [comment:9 Rudraksha Dwivedi]:
> > Since everything appeared clean locally, I expected the GitHub
workflow to pass as well, but the same flake8 issue is still reported in
CI. Could you provide any guidance on what else I should check or what
might cause this discrepancy?
> > Also, on a related note: is it generally acceptable to make several
small commits and pushes to a PR when iterating on CI failures, or is this
discouraged?
> > Thanks again.
>
> I’m also not entirely sure how to answer this part.
> It probably won’t be a big issue, but once you get more familiar with
Django’s CI, I think you won’t have to worry much about these CI-related
concerns :)
hey! Thanks for being patient ! i realised how i had duplicated the same
like of code in two distinct places, also figured out how to setup and
test locally properly
Thanks ^_____^
If the issues dont occur i will mark needs improvement as no
peace ✨
--
Ticket URL: <https://code.djangoproject.com/ticket/36708#comment:11>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
--
You received this message because you are subscribed to the Google Groups
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To view this discussion visit
https://groups.google.com/d/msgid/django-updates/0107019a9a45580c-90f62d7a-b639-4849-948e-b5574c0719ed-000000%40eu-central-1.amazonses.com.
