#36951: task_finished signal logs "NoneType: None" when no exception is raised
-------------------------------------+-------------------------------------
Reporter: Jacob Walls | Owner: Elias
| Hernandis
Type: Bug | Status: assigned
Component: Tasks | Version: 6.0
Severity: Release blocker | Resolution:
Keywords: | Triage Stage: Ready for
| checkin
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by Jacob Walls):
* needs_docs: 1 => 0
* stage: Accepted => Ready for checkin
* summary:
log_task_finished signal logs "NoneType: None" when no exception is
raised
=> task_finished signal logs "NoneType: None" when no exception is
raised
Old description:
> The test provided on [https://github.com/django/django/pull/20722 PR
> #20722] demonstrates that faux exceptions are logged as `NoneType: None`
> by the `log_task_finished` signal:
>
> {{{#!py
> ======================================================================
> FAIL: test_successful_task_no_none_type_in_logs
> (tasks.test_immediate_backend.ImmediateBackendTestCase.test_successful_task_no_none_type_in_logs)
> ----------------------------------------------------------------------
> Traceback (most recent call last):
> File "/Users/jwalls/django/tests/tasks/test_immediate_backend.py", line
> 238, in test_successful_task_no_none_type_in_logs
> self.assertNotIn("NoneType", log_output)
> ~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^
> AssertionError: 'NoneType' unexpectedly found in 'INFO:django.tasks:Task
> id=1yKnLbcmTGMEUfj0B1JG0766LDM1Sono path=tasks.tasks.noop_task
> state=SUCCESSFUL\nNoneType: None'
>
> ----------------------------------------------------------------------
> }}}
New description:
The test provided on [https://github.com/django/django/pull/20722 PR
#20722] demonstrates that faux exceptions are logged as `NoneType: None`
by the `log_task_finished` signal handler:
{{{#!py
======================================================================
FAIL: test_successful_task_no_none_type_in_logs
(tasks.test_immediate_backend.ImmediateBackendTestCase.test_successful_task_no_none_type_in_logs)
----------------------------------------------------------------------
Traceback (most recent call last):
File "/Users/jwalls/django/tests/tasks/test_immediate_backend.py", line
238, in test_successful_task_no_none_type_in_logs
self.assertNotIn("NoneType", log_output)
~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^
AssertionError: 'NoneType' unexpectedly found in 'INFO:django.tasks:Task
id=1yKnLbcmTGMEUfj0B1JG0766LDM1Sono path=tasks.tasks.noop_task
state=SUCCESSFUL\nNoneType: None'
----------------------------------------------------------------------
}}}
--
--
Ticket URL: <https://code.djangoproject.com/ticket/36951#comment:5>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
--
You received this message because you are subscribed to the Google Groups
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To view this discussion visit
https://groups.google.com/d/msgid/django-updates/0107019c95d81a2f-86c55413-14c6-41bb-abac-3fb0d9a14c6e-000000%40eu-central-1.amazonses.com.
