Author: adrian
Date: 2008-09-08 21:18:06 -0500 (Mon, 08 Sep 2008)
New Revision: 8990

Modified:
   django/trunk/django/core/management/commands/dbshell.py
Log:
Fixed #8978 -- We now print a helpful error message for 'manage.py dbshell' if 
the client executable is not found. Previously we were displaying a traceback

Modified: django/trunk/django/core/management/commands/dbshell.py
===================================================================
--- django/trunk/django/core/management/commands/dbshell.py     2008-09-09 
02:13:58 UTC (rev 8989)
+++ django/trunk/django/core/management/commands/dbshell.py     2008-09-09 
02:18:06 UTC (rev 8990)
@@ -1,4 +1,4 @@
-from django.core.management.base import NoArgsCommand
+from django.core.management.base import NoArgsCommand, CommandError
 
 class Command(NoArgsCommand):
     help = "Runs the command-line client for the current DATABASE_ENGINE."
@@ -7,4 +7,12 @@
 
     def handle_noargs(self, **options):
         from django.db import connection
-        connection.client.runshell()
+        try:
+            connection.client.runshell()
+        except OSError:
+            # Note that we're assuming OSError means that the client program
+            # isn't installed. There's a possibility OSError would be raised
+            # for some other reason, in which case this error message would be
+            # inaccurate. Still, this message catches the common case.
+            raise CommandError('You appear not to have the %r program 
installed or on your path.' % \
+                connection.client.executable_name)


--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to [email protected]
To unsubscribe from this group, send email to [EMAIL PROTECTED]
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en
-~----------~----~----~----~------~----~------~--~---

Reply via email to