#9446: Apparent discrepancy between online documentation and how the code works
for custom File Storage system
-----------------------------------------+----------------------------------
Reporter: xhad | Owner: nobody
Status: new | Milestone: post-1.0
Component: Documentation | Version: SVN
Keywords: file storage, documentation | Stage: Unreviewed
Has_patch: 0 |
-----------------------------------------+----------------------------------
The online documentation for writing custom File Storage systems says that
the {{{_save}}} method must be overridden and "No return value is
expected." (http://docs.djangoproject.com/en/dev/howto/custom-file-storage
/#save-name-content).
However, the inherited {{{save}}} method in
{{{django/core/files/storage.py}}} contains these lines (45-48):
{{{
name = self._save(name, content)
# Store filenames with forward slashes, even on Windows
return force_unicode(name.replace('\\', '/'))
}}}
The obvious problem is that returning nothing from the {{{_save}}} method
causes the last line to throw an error like this:
{{{
AttributeError: 'NoneType' object has no attribute 'replace'
}}}
From what I can tell, the documentation should state that the {{{_save}}}
method should be implemented so that it returns the name of the file that
was written to in the end. This seems to be consistent with how the code
is really implemented and how the {{{FileSystemStorage}}} class is
implemented in the same file.
--
Ticket URL: <http://code.djangoproject.com/ticket/9446>
Django <http://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups
"Django updates" group.
To post to this group, send email to [email protected]
To unsubscribe from this group, send email to [EMAIL PROTECTED]
For more options, visit this group at
http://groups.google.com/group/django-updates?hl=en
-~----------~----~----~----~------~----~------~--~---
