#9964: Transaction middleware closes the transaction only when it's marked as
dirty
---------------------------------------------------+------------------------
Reporter: ishirav | Owner:
mtredinnick
Status: assigned | Milestone: 1.2
Component: Database layer (models, ORM) | Version: 1.0-beta-1
Resolution: | Keywords:
transactions
Stage: Accepted | Has_patch: 1
Needs_docs: 1 | Needs_tests: 0
Needs_better_patch: 0 |
---------------------------------------------------+------------------------
Comment (by shai):
Hi,
Replying to [comment:15 russellm]:
> After discussing with Jacob and Malcolm, we've decided to defer this one
from v1.1.
>
I understand how busy you all are; still, I hope you can find the time to
respond while the topic is fresh in your heads.
> having a user-space setting to determine transaction behavior is a non-
starter.
>
Could you please elaborate on this a little? I find it confusing, as the
setting activating the transaction middleware (as all middlewares) is in
the same space as the setting proposed in the patch.
> From a design perspective, there are some subtle tradeoffs that need to
be considered here, including weighing the cost/benefit of "always
commit",
> and ensuring that manual transaction control will continue to work for
those that need every last nanosecond of performance.
>
This I also find confusing, as almost everything that is non-trivial here
is intended to keep the current behavior available for people who need it
(and in fact, keep it through the upgrade for existing projects). Perhaps
I misunderstand, but it seems like you are trying to decide on the always-
close-transaction issue, when the patch jumps through hoops in order to
defer this very decision -- to users for now, and to the future in
general.
> On the flipside - the existing behavior works, as long as you understand
what "works" means.
In this case, would you consider documentation patches (as proposed in
#9919)?
Thanks,
Shai.
--
Ticket URL: <http://code.djangoproject.com/ticket/9964#comment:16>
Django <http://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups
"Django updates" group.
To post to this group, send email to [email protected]
To unsubscribe from this group, send email to
[email protected]
For more options, visit this group at
http://groups.google.com/group/django-updates?hl=en
-~----------~----~----~----~------~----~------~--~---
