#12830: Jquery not includedd when actions=None in admin
-------------------------------------------+--------------------------------
          Reporter:  kickme444             |         Owner:  nobody            
            Status:  closed                |     Milestone:  1.2               
         Component:  django.contrib.admin  |       Version:  1.2-beta          
        Resolution:  duplicate             |      Keywords:  jquery, javascript
             Stage:  Unreviewed            |     Has_patch:  0                 
        Needs_docs:  0                     |   Needs_tests:  0                 
Needs_better_patch:  0                     |  
-------------------------------------------+--------------------------------
Changes (by kmtracey):

  * status:  new => closed
  * needs_better_patch:  => 0
  * needs_tests:  => 0
  * needs_docs:  => 0
  * resolution:  => duplicate

Old description:

> In the admin interface, if you have a ModelAdmin class specifying
> actions=None, jquery.min.js is not included in the template.  However, in
> change_list.html there is the following code:
>
> <script type="text/javascript">
> (function($) {
>     $(document).ready(function($) {
>         $("tr input.action-select").actions();
>     });
> })(jQuery.noConflict());
> </script>
>
> It is my opinion that jquery.min.js should be included in every admin
> page.  My reasoning for this is that I have overridden a few of the admin
> templates to make use of jquery and I need to know that jquery will be
> available.

New description:

 In the admin interface, if you have a !ModelAdmin class specifying
 actions=None, jquery.min.js is not included in the template.  However, in
 change_list.html there is the following code:
 {{{
 <script type="text/javascript">
 (function($) {
     $(document).ready(function($) {
         $("tr input.action-select").actions();
     });
 })(jQuery.noConflict());
 </script>
 }}}
 It is my opinion that jquery.min.js should be included in every admin
 page.  My reasoning for this is that I have overridden a few of the admin
 templates to make use of jquery and I need to know that jquery will be
 available.

Comment:

 Fixed formatting, please use preview prior to submit.

 This sounds like #12396, which was fixed after beta1. (The fix does not
 include jquery in every admin page -- if you want to propose that you may
 want to bring it up on IRC or the dev list.)

-- 
Ticket URL: <http://code.djangoproject.com/ticket/12830#comment:1>
Django <http://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to 
[email protected].
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Reply via email to