#12890: extra() tables included twice do not generate aliases
---------------------------------------------------+------------------------
          Reporter:  semenov                       |         Owner:  nobody
            Status:  new                           |     Milestone:        
         Component:  Database layer (models, ORM)  |       Version:  1.1   
        Resolution:                                |      Keywords:        
             Stage:  Accepted                      |     Has_patch:  0     
        Needs_docs:  0                             |   Needs_tests:  0     
Needs_better_patch:  0                             |  
---------------------------------------------------+------------------------
Changes (by russellm):

  * needs_better_patch:  => 0
  * stage:  Unreviewed => Accepted
  * needs_tests:  => 0
  * needs_docs:  => 0

Comment:

 I'm not convinced that this isn't a user-error. .extra() is a place in the
 API where we have opened up holes, and let users drop things into those
 holes, but the onus is on the user to put meaningful things into those
 holes. Since this is a freeform part of the query, there are limits on
 what we can do. Building an alias for an extra() specified table isn't an
 option, because we can't rewrite the extra where clause.

 However, we should probably raise an error so this is caught before it
 hits the database.

-- 
Ticket URL: <http://code.djangoproject.com/ticket/12890#comment:1>
Django <http://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to 
[email protected].
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Reply via email to