#11797: Test Client Response content form value parsing
---------------------------------------------+------------------------------
Reporter: Rupe | Owner: Rupe
Status: assigned | Milestone: 1.3
Component: Testing framework | Version: SVN
Resolution: | Keywords: test client
content form post get
Stage: Design decision needed | Has_patch: 1
Needs_docs: 0 | Needs_tests: 0
Needs_better_patch: 0 |
---------------------------------------------+------------------------------
Comment (by kmike):
I like your intentions very much because this is really a better way to
write tests than django's current method.
But I think that in practice efforts to support this feature can outweighs
benefits it provide.
For example, your patch uses HTMLParser. HTMLParser is known for it's bad
parsing of normal real-world (but maybe invalid) HTML. This is one of the
reasons there are a lot of other parsing libraries (lxml, BeautifulSoup,
html5lib, ...). So there will be tickets complaining about test client
html parsing. So there will be patches and HTMLParser workarounds - and
this can eventually lead to django's own half-baked html parsing library.
The benefit over using django-test-utils or django-webtest is only an
easier testing of django itself.
But converting django test suite to use new method also have some
downsides: html parsing takes time and test suite will run longer.
Existing suite is huge and converting it is a non-trivial work.
I'm not a core developer and they possibly don't share my point of view so
take all these as a personal opinion. This is all about balance and
balance is a subjective matter.
--
Ticket URL: <http://code.djangoproject.com/ticket/11797#comment:18>
Django <http://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
--
You received this message because you are subscribed to the Google Groups
"Django updates" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/django-updates?hl=en.
