#12398: Add `TypedMultipleChoiceField` to compliment `TypedChoiceField`.
--------------------------------+-------------------------------------------
Reporter: mrmachine | Owner: nobody
Status: new | Milestone:
Component: Forms | Version:
Resolution: | Keywords:
Stage: Accepted | Has_patch: 1
Needs_docs: 0 | Needs_tests: 0
Needs_better_patch: 1 |
--------------------------------+-------------------------------------------
Changes (by lukeplant):
* needs_better_patch: 0 => 1
Comment:
Looks fairly good to me. A few things:
* I would change the comment that starts "Hack alert", because I don't
think it is a hack, and I think the comment about catching both exceptions
is incorrect - it catches one and raises another.
* The patch doesn't apply cleanly at the moment. The tests have moved.
* The test names are strange - why do they start at 70 instead of 1?
With these addressed, feel free to move to Ready For Checkin.
--
Ticket URL: <http://code.djangoproject.com/ticket/12398#comment:3>
Django <http://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
--
You received this message because you are subscribed to the Google Groups
"Django updates" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/django-updates?hl=en.
