#12595: Localflavor bad arguments handling
------------------------------------+-------------------------------------
Reporter: sayane | Owner:
Type: Bug | Status: new
Milestone: | Component: contrib.localflavor
Version: | Severity: Normal
Resolution: | Keywords:
Triage Stage: Accepted | Has patch: 1
Needs documentation: 0 | Needs tests: 1
Patch needs improvement: 1 | Easy pickings: 0
------------------------------------+-------------------------------------
Changes (by claudep):
* needs_better_patch: 0 => 1
* easy: => 0
Comment:
I basically see what's the problem and what to do. Now there is a lot of
similar changes to make, and I would like to know if I'm going in the
right direction before giving more time to this.
See my patch, and tell me if it's OK (and good practice) to pass
max_length and min_length to super as args (vs kwargs).
For tests, should I add field_kwargs to all tests, or add a second assert
with field_kwargs to all tests, or simply add field_kwargs once per test
case?
--
Ticket URL: <http://code.djangoproject.com/ticket/12595#comment:9>
Django <http://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
--
You received this message because you are subscribed to the Google Groups
"Django updates" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/django-updates?hl=en.
