#16288: Enabling 'django.request' logger when DEBUG is True
---------------------------------------+------------------------------
Reporter: mattbennett | Owner: nobody
Type: New feature | Status: new
Milestone: | Component: Core (Other)
Version: SVN | Severity: Normal
Resolution: | Keywords: logging
Triage Stage: Accepted | Has patch: 1
Needs documentation: 0 | Needs tests: 0
Patch needs improvement: 0 | Easy pickings: 0
UI/UX: 0 |
---------------------------------------+------------------------------
Comment (by carljm):
I've put together a proposed patch including the backward-compat shim,
with tests, and using a CallbackFilter (like ConditionFilter but accepts
callable rather than plain value so the DEBUG check isn't so eager). Also
includes documentation updates. I've also tested it manually under all the
conditions (new project template with DEBUG on or off, old project
template needing back-compat shim with DEBUG on or off) and it works as
expected.
Patch is attached, and in a github branch:
https://github.com/carljm/django/compare/master...t16288-debug-request-
logging
Review and verification welcome; I'll leave this here for a few days at
least so anyone interested can review it before I commit; if you'd like to
review before it goes in but don't have time in the next day or so, let me
know and I'll wait.
--
Ticket URL: <https://code.djangoproject.com/ticket/16288#comment:7>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
--
You received this message because you are subscribed to the Google Groups
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at
http://groups.google.com/group/django-updates?hl=en.
