#16288: Enabling 'django.request' logger when DEBUG is True
---------------------------------------+------------------------------
Reporter: mattbennett | Owner: nobody
Type: New feature | Status: new
Milestone: | Component: Core (Other)
Version: SVN | Severity: Normal
Resolution: | Keywords: logging
Triage Stage: Accepted | Has patch: 1
Needs documentation: 0 | Needs tests: 0
Patch needs improvement: 0 | Easy pickings: 0
UI/UX: 0 |
---------------------------------------+------------------------------
Comment (by carljm):
Replying to [comment:8 russellm]:
> Patch looks good to me. My only feedback would be that the text of the
PendingDeprecationWarning is a bit verbose for my taste; historically,
we've gone with a terse message that directs attention to the release
notes.
Thanks for the review - I've reduced the verbosity on the deprecation
warning, making it primarily a link to the release notes.
> Following up on my "noisy" comment -- my concern is that this shim is on
a code path that is executed on every single request, so any code overhead
needs to be considered carefully. The patch you've proposed falls back to
a function call plus an 'in' check for the doing-it-right case, which I
think we can live with.
I don't think that's right, unless I'm missing something. The shim code in
my patch runs in `Settings.__init__`, which runs only when settings are
first initialized, which is once per server process (twice with manage.py
due to its oddities), not once per request. I've played around with it
using "python -W all manage.py runserver" and never see the warning any
time other than at startup. So I don't think the shim/warning is either
noisy or a performance concern.
--
Ticket URL: <https://code.djangoproject.com/ticket/16288#comment:9>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
--
You received this message because you are subscribed to the Google Groups
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at
http://groups.google.com/group/django-updates?hl=en.
