#16650: BaseCommentNode in comments template tags shouldn't filter "is_public"
comments
-------------------------+----------------------------------
 Reporter:  semente      |          Owner:  nobody
     Type:  Bug          |         Status:  new
Milestone:               |      Component:  contrib.comments
  Version:  1.3          |       Severity:  Normal
 Keywords:  templatetag  |   Triage Stage:  Unreviewed
Has patch:  0            |  Easy pickings:  1
    UI/UX:  0            |
-------------------------+----------------------------------
 The template tag {{{ get_comment_list }}} should query all comments
 instead only the {{{ is_public }}} ones.

 Why? The developer might want show a message "Comment waiting for
 moderation." instead just hide it completely. A developer can simple don't
 show those comments with a {{{ if }}} in the template if he want hide non-
 public comments.

 I know that is not a big problem and also that is a backward-incompatible
 change, but IMHO that is not a good behavior.

-- 
Ticket URL: <https://code.djangoproject.com/ticket/16650>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Reply via email to