#12308: Adding tablespace support to postgres backends
-------------------------------------+-------------------------------------
Reporter: tclineks | Owner: aaugustin
Type: New | Status: new
feature | Component: Database layer
Milestone: | (models, ORM)
Version: SVN | Severity: Normal
Resolution: | Keywords:
Triage Stage: Accepted | Has patch: 1
Needs documentation: 0 | Needs tests: 0
Patch needs improvement: 0 | Easy pickings: 0
UI/UX: 0 |
-------------------------------------+-------------------------------------
Changes (by akaariai):
* needs_better_patch: 1 => 0
Comment:
The pattern you use is fine if the "supports_tablespaces" should not be
used when creating the SQL. I was thinking that your code is checking the
support for tablespaces by checking if the tablespace_sql() method returns
an empty string, while there is also a flag which tells you that. And that
seemed wrong. After your explanation that doesn't seem wrong any more.
So, at this point I have the following items:
- trivial typo in documentation: "These is useful for setting ...".
- As mentioned by author, the patch lacks `__init__`.py for the
tests/modeltests/tablespaces/ directory.
So, I guess the patch is ready for committer who can do the final polish.
I won't mark this ready for checkin, as I have no possibility to test this
on Oracle, nor do I know how to actually compile the documentation. Maybe
I am taking the "ready for checkin" a bit too literally? :)
--
Ticket URL: <https://code.djangoproject.com/ticket/12308#comment:19>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
--
You received this message because you are subscribed to the Google Groups
"Django updates" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/django-updates?hl=en.
