Author: PaulM
Date: 2011-09-21 22:36:57 -0700 (Wed, 21 Sep 2011)
New Revision: 16878
Modified:
django/branches/releases/1.3.X/django/contrib/admin/forms.py
django/branches/releases/1.3.X/tests/regressiontests/admin_views/tests.py
Log:
[1.3.X] Fixed #16837 -- Improved error messages for admin login. Thanks Wim
Feijen for the patch.
Modified: django/branches/releases/1.3.X/django/contrib/admin/forms.py
===================================================================
--- django/branches/releases/1.3.X/django/contrib/admin/forms.py
2011-09-22 05:21:51 UTC (rev 16877)
+++ django/branches/releases/1.3.X/django/contrib/admin/forms.py
2011-09-22 05:36:57 UTC (rev 16878)
@@ -6,8 +6,8 @@
from django.utils.translation import ugettext_lazy, ugettext as _
-ERROR_MESSAGE = ugettext_lazy("Please enter a correct username and password. "
- "Note that both fields are case-sensitive.")
+ERROR_MESSAGE = ugettext_lazy("Please enter the correct username and password "
+ "for a staff account. Note that both fields are case-sensitive.")
class AdminAuthenticationForm(AuthenticationForm):
"""
Modified:
django/branches/releases/1.3.X/tests/regressiontests/admin_views/tests.py
===================================================================
--- django/branches/releases/1.3.X/tests/regressiontests/admin_views/tests.py
2011-09-22 05:21:51 UTC (rev 16877)
+++ django/branches/releases/1.3.X/tests/regressiontests/admin_views/tests.py
2011-09-22 05:36:57 UTC (rev 16878)
@@ -38,7 +38,10 @@
Question, Answer, Inquisition, Actor, FoodDelivery,
RowLevelChangePermissionModel, Paper, CoverLetter, Story, OtherStory)
+ERROR_MESSAGE = "Please enter the correct username and password \
+for a staff account. Note that both fields are case-sensitive."
+
class AdminViewBasicTest(TestCase):
fixtures = ['admin-views-users.xml', 'admin-views-colors.xml',
'admin-views-fabrics.xml', 'admin-views-books.xml']
@@ -638,12 +641,12 @@
self.assertContains(login, "Your e-mail address is not your username")
# only correct passwords get a username hint
login = self.client.post('/test_admin/admin/',
self.super_email_bad_login)
- self.assertContains(login, "Please enter a correct username and
password.")
+ self.assertContains(login, ERROR_MESSAGE)
new_user = User(username='jondoe', password='secret',
email='[email protected]')
new_user.save()
# check to ensure if there are multiple e-mail addresses a user
doesn't get a 500
login = self.client.post('/test_admin/admin/', self.super_email_login)
- self.assertContains(login, "Please enter a correct username and
password.")
+ self.assertContains(login, ERROR_MESSAGE)
# Add User
request = self.client.get('/test_admin/admin/')
@@ -674,7 +677,7 @@
self.assertEqual(request.status_code, 200)
login = self.client.post('/test_admin/admin/', self.joepublic_login)
self.assertEqual(login.status_code, 200)
- self.assertContains(login, "Please enter a correct username and
password.")
+ self.assertContains(login, ERROR_MESSAGE)
# Requests without username should not return 500 errors.
request = self.client.get('/test_admin/admin/')
@@ -1234,12 +1237,12 @@
self.assertContains(login, "Your e-mail address is not your username")
# only correct passwords get a username hint
login = self.client.post('/test_admin/admin/secure-view/',
self.super_email_bad_login)
- self.assertContains(login, "Please enter a correct username and
password.")
+ self.assertContains(login, ERROR_MESSAGE)
new_user = User(username='jondoe', password='secret',
email='[email protected]')
new_user.save()
# check to ensure if there are multiple e-mail addresses a user
doesn't get a 500
login = self.client.post('/test_admin/admin/secure-view/',
self.super_email_login)
- self.assertContains(login, "Please enter a correct username and
password.")
+ self.assertContains(login, ERROR_MESSAGE)
# Add User
request = self.client.get('/test_admin/admin/secure-view/')
@@ -1271,7 +1274,7 @@
login = self.client.post('/test_admin/admin/secure-view/',
self.joepublic_login)
self.assertEqual(login.status_code, 200)
# Login.context is a list of context dicts we just need to check the
first one.
- self.assertContains(login, "Please enter a correct username and
password.")
+ self.assertContains(login, ERROR_MESSAGE)
# 8509 - if a normal user is already logged in, it is possible
# to change user into the superuser without error
--
You received this message because you are subscribed to the Google Groups
"Django updates" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/django-updates?hl=en.
