#17097: Permission to delete a comment should be based on a user's given
permissions
----------------------------------+------------------------------------
Reporter: george@… | Owner: nobody
Type: New feature | Status: new
Component: contrib.comments | Version: 1.3
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 1
Needs tests: 1 | Patch needs improvement: 1
Easy pickings: 0 | UI/UX: 0
----------------------------------+------------------------------------
Changes (by julien):
* needs_better_patch: 0 => 1
Comment:
Thanks a lot for your work on this patch!
However, I now think that we should aim for a more general fix. Ideally,
if the user didn't have delete permissions, then the 'delete_selected'
action wouldn't show up -- this applies not just to comments, but to any
model. This general issue is addressed in #10609. I've just remembered
about that ticket and I apologise for not letting you know about it
earlier.
So, to summarise, I would prefer to fix #10609 first, and then clean up
`CommentsAdmin.get_actions()`. Many thanks again!
--
Ticket URL: <https://code.djangoproject.com/ticket/17097#comment:4>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
--
You received this message because you are subscribed to the Google Groups
"Django updates" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/django-updates?hl=en.
