#3881: Don't mask server exception with session save exception
----------------------------------+------------------------------------
     Reporter:  hauserx@…         |                    Owner:  adrian
         Type:  Bug               |                   Status:  reopened
    Component:  contrib.sessions  |                  Version:  1.3-beta
     Severity:  Normal            |               Resolution:
     Keywords:                    |             Triage Stage:  Accepted
    Has patch:  1                 |      Needs documentation:  0
  Needs tests:  0                 |  Patch needs improvement:  0
Easy pickings:  0                 |                    UI/UX:  0
----------------------------------+------------------------------------
Changes (by akaariai):

 * needs_better_patch:  1 => 0


Comment:

 I created a branch implementing the "skip save on 500" idea.
 https://github.com/akaariai/django/tree/ticket_3881

 My reasoning is that in 500 situations the session save is more likely to
 fail than in other situations. In addition the save could easily lead into
 saving incomplete data - the processing of the request likely ended due to
 unexpected error, and thus it is possible that only portion of the
 intended session updates were done.

 I will not commit this patch if I don't get an OK for this patch from
 another core dev. I will make a short post to django-developers about
 this.

-- 
Ticket URL: <https://code.djangoproject.com/ticket/3881#comment:8>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to 
[email protected].
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Reply via email to