#17209: Dogfood class-based views in contrib.auth
-------------------------------------+-------------------------------------
Reporter: melinath | Owner: andrews
Type: | Status: new
Cleanup/optimization | Version: master
Component: contrib.auth | Resolution:
Severity: Normal | Triage Stage: Accepted
Keywords: class-based views | Needs documentation: 0
admin auth | Patch needs improvement: 1
Has patch: 0 | UI/UX: 0
Needs tests: 0 |
Easy pickings: 0 |
-------------------------------------+-------------------------------------
Changes (by mjtamlyn):
* cc: marc.tamlyn@… (added)
* needs_better_patch: 0 => 1
Comment:
I've tried bringing the patch up to the current master. Most of the tests
pass and it seems to be ok, but there's something weird going on with the
way that the wrapper shim works.
On discussion with andrewgodwin we've come up with the following changes:
1) Remove the wrapper shim, and convert all of the keyword arguments to
kwargs. We can handle `extra_context` by updating the context on the
`TemplateResponse` object returned from the CBV.
2) Tests: the new tests should be entirely equivalent to the old tests,
but also separate. So a new set of urls linked to the cbv views, and
retest all the expected behaviour. We should then be able to deprecate
things easily when the time comes.
3) !Docs/Release notes. The functional views documentation can be removed,
and we can convert each part of the docs to now document the new, class
based version.
--
Ticket URL: <https://code.djangoproject.com/ticket/17209#comment:12>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
--
You received this message because you are subscribed to the Google Groups
"Django updates" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit https://groups.google.com/groups/opt_out.
