#18977: bad removal of comments in custom_sql_for_model
-------------------------------+--------------------------------------
Reporter: trott@… | Owner: nobody
Type: Bug | Status: new
Component: Uncategorized | Version: 1.4
Severity: Normal | Resolution:
Keywords: | Triage Stage: Unreviewed
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------+--------------------------------------
Changes (by akaariai):
* needs_docs: => 0
* needs_tests: => 0
* needs_better_patch: => 0
Comment:
I believe we are removing the comments so that we do not try to execute
comment-only strings by cursor.execute(). Could we remove just those
comments and leave the rest in for this ticket.
There is a deeper problem with the raw SQL files. We just can't reliably
parse the SQL into statements. We will need an SQL parser for each version
of each database vendor if we want to get this correct...
I think we really need a better solution for initial (schema) SQL.
--
Ticket URL: <https://code.djangoproject.com/ticket/18977#comment:1>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
--
You received this message because you are subscribed to the Google Groups
"Django updates" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit https://groups.google.com/groups/opt_out.
