#18977: bad removal of comments in custom_sql_for_model
-------------------------------+--------------------------------------
Reporter: trott@… | Owner: nobody
Type: Bug | Status: new
Component: Uncategorized | Version: 1.4
Severity: Normal | Resolution:
Keywords: | Triage Stage: Unreviewed
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------+--------------------------------------
Comment (by anonymous):
Beside this, I'd like to add some comments:
a.) the removal of comments should be re-considered. I think, it's not
Django job to do this.
b.) even the split info separate statements at ";<newline>" boundaries can
result into broken up string values.
c.) please recognize, that the SQL statements of ''ALL'' SQL files are
collected and re-arranged by this function.
This can result into a really large list and memory waste. It would be
better to consider a Python generator based approach.
(In my case the size of all SQL files is about 200MBytes and takes 5
minutes to be loaded&executed).
--
Ticket URL: <https://code.djangoproject.com/ticket/18977#comment:2>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
--
You received this message because you are subscribed to the Google Groups
"Django updates" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit https://groups.google.com/groups/opt_out.
