2007/10/15, Joseph Heck <[EMAIL PROTECTED]>:
>
> Hi David,
>
> If you'd be willing to indulge me, why doesn't DQS doesn't fit your
> requirements? I'd love to have some explicit feedback on where it
> could be improved to match your needs. And yes, I know there's a LOT
> of places where it could be improved... :-)
>

Hi Joe,

Here are a couple of suggestions of what I'd like to do if I need to
use this project:

* Turns it to a RESTful one which mean at least use HTTP verbs instead
of /delete/ and so one in URLs, I will probably use
django-rest-interface to do that.
* Move doctests to the tests.py file and add more tests before the next point.
* Review some parts of the code, for example use queryset.count()
instead of len(queryset), or change this part:

        q = None
        try:
            q = Queue.objects.get(name=queue_name)
        except Queue.DoesNotExist:
            pass
        if q is None:
            return None

To this one:

        try:
            q = Queue.objects.get(name=queue_name)
        except Queue.DoesNotExist:
            return None

I don't know if it works but it seems more natural to me.

Regards,
David

--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups 
"Django users" group.
To post to this group, send email to [email protected]
To unsubscribe from this group, send email to [EMAIL PROTECTED]
For more options, visit this group at 
http://groups.google.com/group/django-users?hl=en
-~----------~----~----~----~------~----~------~--~---

Reply via email to