On Mon, 19 Oct 2009 16:14:30 +0100 Tim Booth <[email protected]> wrote:
> 1 - Currently, if you remove the session name entirely from the config > file then DL won't work. This bit me as I tried to use an old config > file in new DL. I'd suggest putting the default value into the code > and allowing it to be overridden. Patch 1 does this. I think it's too late for that, since 0.3 is already out :(. However, the point is taken. I've commented all non-mandatory flags in config.php, and introduced the variable $cfgVersion (which defaults to the shipped tarball). All files now include confwrap.php instead, which will "mediate" the values, if there is need, so that we can add/remove/change the config.php file in the future, but still allow to read old configurations for smoother upgrades. > 3 - Notification by e-mails is all very well, but most server > administrators want a global log file. This patch adds that > functionality, and also supports syslog. See the note in the > config.php file. I've refined your patch. I've added higher-level hooks for ticket creation/deletion/download into "hooks.php", and moved the notification functions (including file logging) in them.
