On 3 Nov 2009, at 19:54, Tim Booth wrote:
//Mail out... if(!empty($_REQUEST["mailto"])) { $mailto = str_replace(array(";", "\n"), ",", $_REQUEST["mailto"]);mail($mailto, "Files available to download from " . $_SERVER ["SERVER_NAME"],"This message was auto-generated by dl.php\n" ."The download ticket system has made the following files available:\n\n$allurls\n" . ($DATA["expire"] == 0 ? "" : "Links will expire after " . $_REQUEST["hr"] . " hours.\n") . ($DATA["expireLast"] == 0 ? "" : "Links will expire after " . $_REQUEST["hra"] . " hours from first download.\n") . ($DATA["expireDln"] == 0 ? "" : "Links will be valid for " . $_REQUEST["hra"] . " downloads.\n") . ($DATA["lockip"] == "no" ? "" : "Links may only be downloaded on one computer.\n") ,"From: $fromAddr"); } The use of "$allurls" is because I also added the ability to upload multiple files at once and send all the tickets in the one mail. I'm
What happens if somebody uploads 2 files? 2 urls are generated?
not sure if "mailto" should be on the main upload form or if this feature should be triggered by a second form after the upload is done. As you say, things are starting to look a tad cramped on there.
I was thinking of packing all the "fancy" options inside a div, and hide it by default. Maybe in 2 layers (mandatory at the top, basic and expert).
Talking about ip-locking, it would definitely be nice if, when a domain name is inserted, all IPs that reverse to something inside that domain would be allowed. That would make it much more useful IMHO. That would allow for "local" tickets without messing with masks, while still permitting single IP addresses.
