On 4/11/25 03:10, Benjamin Marzinski wrote: >>> Don't we only need to do that if anything is queued up due to a >>> suspension? Then again having a different patch might be premature >>> optimization, it's not like anyone cares about dm-delay performance >>> almost by definition :) >> >> True. I can add a list_empty check here. Will send a v2 with that. > > I may be pointing out the obvious, but we can't just check if > dc->delayed_bios is empty, since we pull the bios off the list before we > submit them. We can only skip adding the bios if the list is empty and > flush_delay_bios() isn't currently processing any bios.
Hehe, obvious when you hear it :) Good point ! I will not try to micro optimize this. -- Damien Le Moal Western Digital Research
