On 6/16/26 12:56 AM, Benjamin Marzinski wrote:
On Mon, Jun 15, 2026 at 11:00:48PM +0200, Xose Vazquez Perez wrote:
On 6/15/26 9:07 PM, Benjamin Marzinski wrote:
This patchset is to deprecate the rr_weight, rr_min_io_rq, and rr_min_io
multipath config options. It's a companion of the patchset to handle
their deprecation in the man pages.
https://lore.kernel.org/all/[email protected]/
It does not completely remove the minio setting code, since there are
ideas for reusing this in the future. The final patch is simply a change
to avoid a kernel warning message that I hit while testing these
patches.
Ben, thanks for this cleanup.
I ran grep to see what remains of these options in the codebase.
Could you please check if any of the following occurrences should have been
removed, or if they are intended to stay for now?
8<---
$ git grep -Ei "rr_weight|minio|min_io" | grep -vE
"multipath.conf.5.in|deprecated"
Good catch. It appears I misses some things.
I ran the following command to locate previous "deprecated keywords":
$ for i in $(git grep -h deprecated libmultipath/dict.c | grep install_keyword | sort | uniq | awk -F\" '{print $2}') ; do printf "\\n\n--- $i\n\n" ; git grep -i $i | grep -vE
"install_keyword|multipath.conf.5.in|\.md|deprecated_handler" ; done
It looks like there is some leftover code that could also be cleaned up, such
as:
--- disable_changed_wwids
libmultipath/defaults.h:#define DEFAULT_DISABLE_CHANGED_WWIDS 1
and also some checks in tests/hwtable.c.
Could you please take a look at these as well?
Regards.
