On Sun, Jul 19, 2026 at 04:57:00PM +0200, Xose Vazquez Perez wrote: > On 6/16/26 9:47 AM, Xose Vazquez Perez wrote: > > > On 6/16/26 12:56 AM, Benjamin Marzinski wrote: > > > > > On Mon, Jun 15, 2026 at 11:00:48PM +0200, Xose Vazquez Perez wrote: > > > > On 6/15/26 9:07 PM, Benjamin Marzinski wrote: > > > > > > > > > This patchset is to deprecate the rr_weight, rr_min_io_rq, and > > > > > rr_min_io > > > > > multipath config options. It's a companion of the patchset to handle > > > > > their deprecation in the man pages. > > > > > https://lore.kernel.org/all/[email protected]/ > > > > > > > > > > It does not completely remove the minio setting code, since there are > > > > > ideas for reusing this in the future. The final patch is simply a > > > > > change > > > > > to avoid a kernel warning message that I hit while testing these > > > > > patches. > > > > > > Ben, thanks for this cleanup. > > > > > > > > I ran grep to see what remains of these options in the codebase. > > > > Could you please check if any of the following occurrences should have > > > > been > > > > removed, or if they are intended to stay for now? > > > > > > > > 8<--- > > > > $ git grep -Ei "rr_weight|minio|min_io" | grep -vE > > > > "multipath.conf.5.in|deprecated" > > > > > > > > > > Good catch. It appears I misses some things. > > > I ran the following command to locate previous "deprecated keywords": > > $ for i in $(git grep -h deprecated libmultipath/dict.c | grep > > install_keyword | sort | uniq | awk -F\" '{print $2}') ; do printf > > "\\n\n--- $i\n\n" ; git grep -i $i | grep -vE "install_keyword| > > multipath.conf.5.in|\.md|deprecated_handler" ; done > > > > It looks like there is some leftover code that could also be cleaned up, > > such as: > > > > --- disable_changed_wwids > > > > libmultipath/defaults.h:#define DEFAULT_DISABLE_CHANGED_WWIDS 1 > > > > and also some checks in tests/hwtable.c. > Is this still necessary in "write_defaults : tests/hwtable.c" ? > > { "bindings_file", NULL }, > { "config_dir", NULL }, > { "multipath_dir", NULL }, >
Yeah. don't think we need to included deprecated config options in our tests, except possibly in a test to make sure that deprecated values aren't used. > Another candidate to drop is the retain_attached_hw_handler infrastructure: > ( grep -Eir "hwhandler|hw_handler" ) > Since Linux 4.3, the kernel always enforces "retain_attached_hw_handler yes". > Because this option is completely obsolete, could it be dropped from > multipath-tools? I'm never sure how far back we need to support kernels. I could easily be convinced that we don't need to worry about kernels before 4.3 with the latest upstream code. If we still do care about 4.2, I would also be open to deprecating the option, and just always having it set to yes. -Ben > > > Regards.
