On Fri, 2018-09-21 at 18:05 -0500, Benjamin Marzinski wrote: > If all_pathgroup failed to allocate a vector for pgp->paths, instead > of > failing after it freed pgp, it would set pgp to NULL and then > dereference it. This patch fixes that. Found by coverity. > > Signed-off-by: Benjamin Marzinski <[email protected]>
Reviewed-by: Martin Wilck <[email protected]> > --- > libmultipath/structs.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/libmultipath/structs.c b/libmultipath/structs.c > index ae847d6..caa178a 100644 > --- a/libmultipath/structs.c > +++ b/libmultipath/structs.c > @@ -165,7 +165,7 @@ alloc_pathgroup (void) > > if (!pgp->paths) { > FREE(pgp); > - pgp = NULL; > + return NULL; > } > > dm_pathgroup_to_gen(pgp)->ops = &dm_gen_pathgroup_ops; -- Dr. Martin Wilck <[email protected]>, Tel. +49 (0)911 74053 2107 SUSE Linux GmbH, GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB 21284 (AG Nürnberg) -- dm-devel mailing list [email protected] https://www.redhat.com/mailman/listinfo/dm-devel
