On Fri, 2018-09-21 at 18:05 -0500, Benjamin Marzinski wrote: > The only thing this patch changes is to remove the check for pp->mpp > before the check for pp->mpp->prflags, since check_path() already > verified that pp->mpp != NULL. This fixes a number of coverity > warnings. > Also, I normalized the spacing and indenting of the nearby code. > > Signed-off-by: Benjamin Marzinski <[email protected]>
Reviewed-by: Martin Wilck <[email protected]> > --- > multipathd/main.c | 10 +++++----- > 1 file changed, 5 insertions(+), 5 deletions(-) > > diff --git a/multipathd/main.c b/multipathd/main.c > index 125a805..3c2fe7b 100644 > --- a/multipathd/main.c > +++ b/multipathd/main.c > @@ -1978,14 +1978,14 @@ check_path (struct vectors * vecs, struct > path * pp, int ticks) > return 1; > } > > - if(newstate == PATH_UP || newstate == PATH_GHOST){ > - if ( pp->mpp && pp->mpp->prflag ){ > + if (newstate == PATH_UP || newstate == PATH_GHOST) { > + if (pp->mpp->prflag) { > /* > * Check Persistent Reservation. > */ > - condlog(2, "%s: checking persistent reservation > " > - "registration", pp->dev); > - mpath_pr_event_handle(pp); > + condlog(2, "%s: checking persistent " > + "reservation registration", pp- > >dev); > + mpath_pr_event_handle(pp); > } > } > -- Dr. Martin Wilck <[email protected]>, Tel. +49 (0)911 74053 2107 SUSE Linux GmbH, GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB 21284 (AG Nürnberg) -- dm-devel mailing list [email protected] https://www.redhat.com/mailman/listinfo/dm-devel
