On 1/6/2013 5:52 PM, Jonathan M Davis wrote:
Ideally, yes. In reality, it would probably be a problem. We have plenty of problems with reviews being a bottleneck already. However, even if no one else reviews your pull requests, simply going through the process of creating a pull request and letting the pull tester test it will prevent problems involving files being forgotten or breaking platforms that you don't necessarily test on. And if you _do_ test them all already, then maybe the pull request will save you some of that effort. But it doesn't seem to be all that uncommon that you end up having to make commits to unbreak the build because you forgot to commit a file. And using pull requests would catch all that sort of stuff. It would also make sure that it's all working on machines other than your own. - Jonathan M Davis
I test on all platforms here except FreeBSD64. I have a nice build farm in the basement :-)
Yeah, I forget to push a file once in a while. And then I fix it. _______________________________________________ dmd-internals mailing list [email protected] http://lists.puremagic.com/mailman/listinfo/dmd-internals
