On 1/6/2013 6:32 PM, Walter Bright wrote: > > On 1/6/2013 5:52 PM, Jonathan M Davis wrote: >> Ideally, yes. In reality, it would probably be a problem. We have plenty of >> problems with reviews being a bottleneck >> already. However, even if no one else reviews your pull requests, simply >> going through the process of creating a pull >> request and letting the pull tester test it will prevent problems involving >> files being forgotten or breaking >> platforms that you don't necessarily test on. And if you _do_ test them all >> already, then maybe the pull request will >> save you some of that effort. But it doesn't seem to be all that uncommon >> that you end up having to make commits to >> unbreak the build because you forgot to commit a file. And using pull >> requests would catch all that sort of stuff. It >> would also make sure that it's all working on machines other than your own. >> - Jonathan M Davis > > I test on all platforms here except FreeBSD64. I have a nice build farm in > the basement :-)
Costing a lot of time in the process, and still not catching the not infrequent failure to remember a file. Adding those machines to the tester-farm and using the tester would be a net win for all changes. > Yeah, I forget to push a file once in a while. And then I fix it. Sometimes a day later, which is highly annoying and completely avoidable. _______________________________________________ dmd-internals mailing list [email protected] http://lists.puremagic.com/mailman/listinfo/dmd-internals
