I agree with Daniel. Closing PRs just because they are old has no benefit, and
sometimes we do go back, fix one, and pull it, or use it as a guide to making a
better PR.
On 5/7/2016 9:35 AM, Daniel Murphy via dmd-internals wrote:
What would that gain us? I eventually come back to my open PRs...
On Sat, May 7, 2016 at 12:11 AM, Andrej Mitrovic via dmd-internals
<[email protected]> wrote:
It seems that after open pulls page 4 or so on the DMD side of things
a pretty large number of PRs are completely broken and haven't been
touched in months, or worse in years. E.g.
https://github.com/dlang/dmd/pull/4658
There is really no benefit to having PRs just sit idly like that.
I think we could automate the clean-up of stale pulls and we could
even do it in stages:
After X amount of time we could make `dlang-bot` attempt to notify the
author of his stale PR, then let some more time pass again, and if the
PR is still in bad shape `dlang-bot` would close the PR, send a
notification to the PR author about the pull being closed, but also CC
to dmd-internals / phobos-internals / etc in case the author went AWOL
so we have a chance of picking up the work from there.
Thoughts?
_______________________________________________
dmd-internals mailing list
[email protected]
http://lists.puremagic.com/mailman/listinfo/dmd-internals
_______________________________________________
dmd-internals mailing list
[email protected]
http://lists.puremagic.com/mailman/listinfo/dmd-internals
_______________________________________________
dmd-internals mailing list
[email protected]
http://lists.puremagic.com/mailman/listinfo/dmd-internals
