hi Jean

thank you for your response, i followed up privately with some more details.
________________________________
From: Jean Delvare <jdelv...@suse.de>
Sent: 26 August 2019 13:17
To: Deomid Ryabkov <roj...@fb.com>
Cc: dmidecode-devel@nongnu.org <dmidecode-devel@nongnu.org>
Subject: Re: [dmidecode] PATCH: Fix formatting of TPM table output

Hi Deomid,

On Mon, 19 Aug 2019 17:49:40 +0000, Deomid Ryabkov wrote:
> Added missing newlines.
>
> Output before:
> ---
> Handle 0x0036, DMI type 43, 31 bytes
> TPM Device
>         Vendor ID:
>         Specification Version: 9.9      Firmware Revision: 9.99
>         Description: xxx   Characteristics:
>                 Family configurable via platform software support
>         OEM-specific Information: 0x00000000
> ---
> after:
> ---
> Handle 0x0036, DMI type 43, 31 bytes
> TPM Device
>         Vendor ID:
>         Specification Version: 9.9
>         Firmware Revision: 9.99
>         Description: xxx
>         Characteristics:
>                 Family configurable via platform software support
>         OEM-specific Information: 0x00000000
> ---

Doh. Obviously correct. The reason why I missed that is that I did not
have any machine implementing that type when I wrote the code. I still
don't, actually... Would you consider sending me (in private) the
binary dump of your DMI table (as generated by "dmidecode --dump-bin")
so that I can add it to my non-regression test suite?

Consider that one applied too, thanks.

--
Jean Delvare
SUSE L3 Support
_______________________________________________
https://lists.nongnu.org/mailman/listinfo/dmidecode-devel

Reply via email to