On Tue, Apr 08, 2025 at 04:11:45PM +0200, Jean Delvare wrote:
> On Thu, 2025-04-03 at 19:37 -0600, Jerry Hoemann wrote:
> > Format 18 should be in dollar/cents dotation.
>
> Typo in the subject, it's format 18, not 0x18.
Fixed. Switched to decimal.
My problem is that the spec defines all these format types in hex
and I for some reason made the switch case labels in decimal. So,
I keep making conversion mistakes.
Would you mind if the next time I update this function that I send a
patch to convert all the case labels to hex to match the spec?
It would reduce these type of errors.
thanks
>
> > Fixes: 9d2bbd5db427b063da ("dmioem: Decode HPE OEM Record 216")
> > Signed-off-by: Jerry Hoemann <jerry.hoem...@hpe.com>
> > ---
> > dmioem.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/dmioem.c b/dmioem.c
> > index 0cc16a9..c454f3b 100644
> > --- a/dmioem.c
> > +++ b/dmioem.c
> > @@ -595,7 +595,7 @@ static void dmi_hp_216_version(u8 format, u8 *data)
> > pr_attr(name, "%08X", DWORD(data));
> > break;
> > case 18:
> > - pr_attr(name, "%d.%2d", data[0], data[1]);
> > + pr_attr(name, "%d.%02d", data[0], data[1]);
> > break;
> > case 3: /* fall through */
> > default:
>
> Looks good, thanks.
>
> --
> Jean Delvare
> SUSE L3 Support
--
-----------------------------------------------------------------------------
Jerry Hoemann Software Engineer Hewlett Packard Enterprise
-----------------------------------------------------------------------------
