On Tue, Apr 08, 2025 at 04:12:44PM +0200, Jean Delvare wrote: > Hi Jerry, > > On Thu, 2025-04-03 at 19:37 -0600, Jerry Hoemann wrote: > > Update Enumerated Firmware Types. > > Update Enumerated Version Data Format: > > : -> . > > > Signed-off-by: Jerry Hoemann <jerry.hoem...@hpe.com> > > --- > > dmioem.c | 14 ++++++++++++-- > > 1 file changed, 12 insertions(+), 2 deletions(-) > > > > diff --git a/dmioem.c b/dmioem.c > > index c454f3b..94be918 100644 > > --- a/dmioem.c > > +++ b/dmioem.c > > @@ -467,8 +467,8 @@ static void dmi_hp_216_fw_type(u16 code) > > "SPI Descriptor Version", > > "Innovation Engine Firmware (IE Firmware)", > > "UMB Backplane Firmware", > > - "Reserved", /* 0x14 */ > > - "Reserved", > > + "Embedded Diagnostics", > > + "Reserved", /* 0x15 */ > > "Reserved", > > "Reserved", > > "Reserved", > > @@ -511,6 +511,10 @@ static void dmi_hp_216_fw_type(u16 code) > > "Power Distribution Board CPLD", > > "PCIe Switch Board CPLD", > > "Sideband Board CPLD", > > + "PCIe Riser MCU Firmware", /* 0x40 */ > > + "PCIe Switch Board Firmware", > > + "Power Supply Firmware", > > + "BMC Firmware", > > }; > > > > if (code < ARRAY_SIZE(type)) > > @@ -597,6 +601,12 @@ static void dmi_hp_216_version(u8 format, u8 *data) > > case 18: > > pr_attr(name, "%d.%02d", data[0], data[1]); > > break; > > + case 19: > > + pr_attr(name, "0x%02.0x%02x.0x%02x", data[0], data[1], data[2]); > > I assume there's a missing "x" before the first dot?
Fixed. > > > > + break; > > + case 20: > > + pr_attr(name, "%d.%d.%d.%d", data[0], data[1], data[2], > > data[3]); > > + break; > > case 3: /* fall through */ > > default: > > pr_attr(name, "%s", reserved); > > Rest looks good. > > -- > Jean Delvare > SUSE L3 Support -- ----------------------------------------------------------------------------- Jerry Hoemann Software Engineer Hewlett Packard Enterprise -----------------------------------------------------------------------------
