On Wed, 2017-10-04 at 20:43 -0700, Kurt H Maier wrote: > On Wed, Oct 04, 2017 at 07:23:22PM -0700, Rosen Penev wrote: > > > > - if (intname && strlen(intname) != 0) > > + if (!strlen(intname)) > > ifindex = if_nametoindex(intname); /* index == 0 when not > > binding to an interface */ > > How much testing have you done of these patches? >
Compile time. Looks fine to me. To add to my commit message, strlen(NULL) causes a segmentation fault, meaning intname cannot be NULL. Actually I wonder how many more warnings I can find like this... > khm > > _______________________________________________ > Dnsmasq-discuss mailing list > Dnsmasq-discuss@lists.thekelleys.org.uk > http://lists.thekelleys.org.uk/mailman/listinfo/dnsmasq-discuss _______________________________________________ Dnsmasq-discuss mailing list Dnsmasq-discuss@lists.thekelleys.org.uk http://lists.thekelleys.org.uk/mailman/listinfo/dnsmasq-discuss
