On 05/10/2019 09:44, Matthias Andree wrote: > Am 05.10.19 um 09:54 schrieb Geert Stappers: >> Questions: >> Which version of Dnsmasq did work? ( git bi-sect known good) >> Which version of Dnsmasq doesn't work? ( git bi-sect known bad) >> >> In case it is stated in >>> <https://forums.freebsd.org/threads/dnsmasq-tftp-service-not-working-any-longer.72457/#post-440976> >>> <https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=241068> >> have the curitisy to state it here also ... > > FreeBSD have been shipping 2.80 for a long time (since before > 2019-07-01), if there's a mismatch in the source code and what they > quote in the Forums, it'll be easy to spot. > The thing is not that dnsmasq changed, but that FreeBSD changed and it > appears that some interface fiddling makes assumptions that were true in > 11.2 but no longer hold in FreeBSD >= 11.3. > >
The patch in the buzilla entry looks good to me. The dnsmasq code is wrong and has been for some time. The version-dependent failure is probably down to the order in which the data is added to the control array, or the relative size of the two datastructures changing. http://thekelleys.org.uk/gitweb/?p=dnsmasq.git;a=commit;h=936bd82755e8f75fc09c1e9a67fb390175b157d4 should fix things. PLs test. Cheers, Simon. > _______________________________________________ > Dnsmasq-discuss mailing list > Dnsmasq-discuss@lists.thekelleys.org.uk > http://lists.thekelleys.org.uk/mailman/listinfo/dnsmasq-discuss > _______________________________________________ Dnsmasq-discuss mailing list Dnsmasq-discuss@lists.thekelleys.org.uk http://lists.thekelleys.org.uk/mailman/listinfo/dnsmasq-discuss