André Malo wrote:
with the help of google I took a crash course in XSLT and tried to complete your work.
Fun, isn't it? ;-)
* reverted the link colors to the proposed :) the green and the red, weren't a good choice, imho. there was too less contrast between them. (e.g. I have problems with red & green, like about 20% of men)
But now you've chosen red for the <module> entries. I really like to restrict the use of red to things that we want to be important (like security warnings). It is too jarring to see in ordinary text. I stuck with green because <module> and <directive> are highly related concepts. If we can find a color that integrates well, it is fine to make <module> a different color. But I don't like red.
* but, you're right, I removed the underlines of code and module links for better reading
My problem is that there is too many different link colors and actions. I prefer that "hover" trigger only a single, consistent change. In your versions, sometimes hovering adds an underline, and sometimes it removes it. Sometimes it triggers a color change, and sometimes it doesn't. In addition, colors tend to get less forceful when you hover. This seems backwards to me. Hovering should make the link stronger, because it gets you closer to the action.
The color issue I can live with, but the underlining must be consistent. If underline means link, then a:hover should ALWAYS be underlined, regardless of the original state.
* (re?)added proposed semantics (<th> instead of <td>, <ul> in module list etc.)
See my previous email question re the semantics of <th>.
* a lot of small issues, thus the xsl produces proper HTML (e.g. "<example><table>...", used in howto/htaccess.xml)
I don't like the way you handled <example> in the xslt. Your code essentially says "if it is <pre> or <table>, then leave it, otherwise wrap it in <p class="example">". But <example> is a block level element that can take block, inline, or CDATA contents. In the parlance of the XHTML dtd, <example> contains "Flow" contents. That is, it is perfectly acceptable to have a <p> in <example>, or it is perfectly acceptable to have bare text. The correct wrapping of this type of content in xhtml is <div>, not <p>.
(If that doesn't make sense, think of <example> as an element like <blockquote> or <li>. These elements can take pretty much any contents in xhtml. They may contain complete paragraphs in <p>, or they may contain just some simple bare text It would not make any sense (semantically or otherwise) to wrap the entire contents of a <blockquote> in <p>.)
* added doctype and xhtml namespace to xsl:output (manual.en.xsl)
This is good.
Probably we also need some modifications to the DTDs:
Let's address that as a seperate issue. If you want to look at changing that right now, please start a new thread.
Thanks for all your hard work on this.
I'd also like to hear more from people about the overall look and feel.
Joshua.
--------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
