https://bz.apache.org/bugzilla/show_bug.cgi?id=70024

--- Comment #6 from Philippe Cloutier <[email protected]> ---
Created attachment 40176
  --> https://bz.apache.org/bugzilla/attachment.cgi?id=40176&action=edit
Patch (untested)

Thanks Rich, but that depends on how one defines “correctness”. I checked again
and what is clear is that the section is misleading. I am sure that the section
is incoherent, and very confident that what the most problematic sentence
implies is incorrect.

Confirming with Sonnet 4.6 found several issues:
https://claude.ai/share/71b40b99-a667-4d66-b8c4-7e9a39c15c2e
#1 and #2 are those which this tracks. #3 is what I added in comment #4. #4 is
broken, but Claude has a point, which I had not noticed since the other issues
basically hide it.

Point #4 is also interesting in its usage of both “input path” and “subject
string”. In the following, I settled on “subject-path”, but better suggestions
are welcome.

Attempting to solve all that is unrealistic without restructuring, so I bit the
bullet. The attached patch also makes the "list" semantically valid,
implementing the first 3 recommendations from ticket #70020 and cleans up a few
more things, but does *not* constitute a full review of even that list. In
particular, the URL treatment still claims the externality test is merely based
on the host, even though it is surely based on the whole authority (port
included).

Note that the changes are poorly displayed on my local VS Code (they seem more
extensive than they are). Strangely, github.dev understands them considerably
better.

-- 
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to