https://bz.apache.org/bugzilla/show_bug.cgi?id=70024
--- Comment #10 from Rich Bowen <[email protected]> --- Thanks for this patch. The intent — clarifying what Pattern matches and what Substitution replaces — is worthwhile. However, I'd like to suggest a different approach before committing this as-is: 1. Split into smaller patches This bundles at least 4 independent changes. Reviewing and committing separately would be much easier: - (A) Add [!] to the syntax line — trivial, can commit immediately - (B) Consolidate the Negation note — low-risk reformatting - (C) Rewrite "What is matched?" section - (D) Restructure Substitution section from <dl> to nested <ul> 2. Guide vs. reference doc placement The expanded Rewrite Guide (docs/manual/rewrite/) has recently been substantially rewritten. Much of what this patch adds to the directive synopsis is already covered: - VirtualHost vs. per-directory matching → rewrite/htaccess.xml §"What URL does the rule see?" - Directory-path stripping → rewrite/htaccess.xml §"path-stripping" - Sequential rule application → rewrite/tech.xml §"API Phases" The httpd docs deliberately separate terse reference (mod/*.xml) from explanatory guide content (rewrite/*.xml). I'd prefer to keep the directive synopsis concise and cross-reference the guide rather than duplicating tutorial-level explanations inline. 3. On "subject-path" terminology I'd rather not introduce new terminology here. The relevant concepts already have well-defined names in RFC 7230/9110 (request-target, path) and in httpd's own vocabulary (URL-path, filesystem path). Coining "subject-path" doesn't clarify — it adds a term readers then have to map back to the standard ones. The current approach of explaining contextually what the pattern is matched against is sufficient. 4. Technical concerns - "The subject-path and directives such as DocumentRoot and Alias determine the currently mapped filesystem path" — this inverts the causality. DocumentRoot/Alias determine the mapped path; the prefix is stripped from that to produce what the pattern sees. - "satisfied if and only if the pattern has at least 1 match" — a regex either matches a string or it doesn't. This phrasing implies multiple matches are possible against a single string. Suggested path forward: - Commit patches A and B directly - For C and D: consider whether the content you want to add is already in the Rewrite Guide docs. If it's not there, that's where it should go — with a cross-reference from the directive synopsis. Happy to discuss further. -- You are receiving this mail because: You are the assignee for the bug. --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
