#1693: missing return value on Doctrine_Connection::rollback
-----------------------------------+----------------------------------------
Reporter: dominicclifton | Owner: jwage
Type: defect | Status: new
Priority: major | Milestone: 1.0.5
Component: Attributes | Version: 1.0.3
Keywords: transaction rollback | Has_test: 0
Mystatus: Pending Core Response | Has_patch: 0
-----------------------------------+----------------------------------------
`Connection.php`
{{{
/**
* rollback
* ...
* @return boolean false if rollback couldn't
be performed, true otherwise
*/
public function rollback($savepoint = null)
{
$this->transaction->rollback($savepoint);
}
}}}
there's no return keyword.
This missing return value also implies that if there are any unit tests
for rollback then they need to be checked - or some should be created if
they don't exist.
--
Ticket URL: <http://trac.doctrine-project.org/ticket/1693>
Doctrine <http://www.phpdoctrine.org>
PHP Doctrine Object Relational Mapper
--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups
"doctrine-svn" group.
To post to this group, send email to [email protected]
To unsubscribe from this group, send email to [EMAIL PROTECTED]
For more options, visit this group at
http://groups.google.co.uk/group/doctrine-svn?hl=en-GB
-~----------~----~----~----~------~----~------~--~---
