On 23/03/11 16:45, Anders Logg wrote: > On Wed, Mar 23, 2011 at 09:42:08AM -0700, Johan Hake wrote: >> Hi! >> >> I got a request to implement a typemap for >> >> std:vector<boost::shared_ptr<Foo> > >> >> a while back. >> >> Should it be: >> >> 1) std:vector<boost::shared_ptr<Foo> >& >> >> or >> >> 2) std:vector<boost::shared_ptr<Foo> > >> >> I guess copying of shared_ptr aren't that costly. But we need to be >> consistent: >> >> Form >> >> use the first version and >> >> ErrorControl >> >> use the second version. I have no intention writing a typemap for both ;) > > I think (1) even if the copying is not costly. So it needs to be > changed in ErrorControl. >
Seems to me that (1) defeats the purpose of shared pointers. If we use a reference to a std::vector and store it in a class, we have a problem when the vector goes out of scope. Garth > -- > Anders > > >> Johan >> >> _______________________________________________ >> Mailing list: https://launchpad.net/~dolfin >> Post to : [email protected] >> Unsubscribe : https://launchpad.net/~dolfin >> More help : https://help.launchpad.net/ListHelp > > _______________________________________________ > Mailing list: https://launchpad.net/~dolfin > Post to : [email protected] > Unsubscribe : https://launchpad.net/~dolfin > More help : https://help.launchpad.net/ListHelp _______________________________________________ Mailing list: https://launchpad.net/~dolfin Post to : [email protected] Unsubscribe : https://launchpad.net/~dolfin More help : https://help.launchpad.net/ListHelp
