On Wed, Mar 23, 2011 at 10:06:27AM -0700, Johan Hake wrote: > On Wednesday March 23 2011 09:58:34 Anders Logg wrote: > > On Wed, Mar 23, 2011 at 09:53:04AM -0700, Johan Hake wrote: > > > On Wednesday March 23 2011 09:45:13 Anders Logg wrote: > > > > I think (1) even if the copying is not costly. So it needs to be > > > > changed in ErrorControl. > > > > > > On Wednesday March 23 2011 09:46:59 Garth N. Wells wrote: > > > > We should go with (2). > > > > Why (2)? > > > > We use references (or pointers) for all arguments that are not > > primitive types (int, double, (shared) pointers). But as I said, > > there's little to gain in efficiency here by using a reference so if > > there are good reasons (like easier to implement the typemap) we can > > do (1). > > Do big deal for the typemap. I have now implemented Garth view, and it looks > like it is working. Should I remove:
ok, great! > Form(const ufc::form& ufc_form, > const std::vector<const FunctionSpace*>& function_spaces, > const std::vector<const GenericFunction*>& coefficients); > > ? Yes. -- Anders _______________________________________________ Mailing list: https://launchpad.net/~dolfin Post to : [email protected] Unsubscribe : https://launchpad.net/~dolfin More help : https://help.launchpad.net/ListHelp
