So, are we following PSR-2 or not? I am seeing Pull Request accepted that are not following it and I'm quite surprised right now.
Regards, *Marcos García* marcos...@gmail.com 2012-08-04 17:39 GMT+02:00 Laurent Destailleur (eldy) <e...@destailleur.fr>: > Well, there is so many way of working, so this is what i suggest : > > * We user PSR2 : > https://github.com/php-fig/fig-standards/blob/master/accepted/PSR-2-coding-style-guide.md > > * Except for indentation that must be set to: Tabs = 4 spaces and we > don't replace tabs with spaces but we keep the tab (PSR2 says we mut > replace space by tabs). Reason is: > This is the default option for Eclipse (Eclipse does not replace with > space by default), so most developer will work like this. And above all, if > you replace tabs with spaces, there is no way to use ALT-TAB to reduce nb > of tabs: when we want to reduce a part of indented code of one level, we > must remove manually spaces on each lines. Very boring. > > So I update the wiki to add this on page to explain all options to match > this rules : > > http://wiki.dolibarr.org/index.php/Environment_and_development_tools#Install_Eclipse > > > > Le 03/08/2012 18:27, Régis Houssin a écrit : > > c'est dans PSR-2 > > http://www.geek-directeur-technique.com/2012/06/19/normes-php-psr-2-aie-rate/ > > Le 03/08/12 18:17, Doursenaud, Raphaël a écrit : > > Wow ! > > What about the PSR-1 standard you prompted to use some time ago ? > It actully says on line 2 « code MUST use 4 spaces for indenting, not tabs > » > > Laurent's reply in the thread was also very wise as this doesn't matter > as long as everyone uses 4 as their tab setting in their favorite editor. > > I prefer spaces thou, because it doesn't look ugly whatever the > settings are. > > Cheers, > > > 2012/8/3 Régis Houssin <regis.hous...@cap-networks.com> > >> Hi, >> >> tabs >> in eclipse, a tab corresponding to 4 spaces by default >> >> >> Le 03/08/12 14:35, Marcos García a écrit : >> >> Hi, >> >> One question, what do you officially use to indent in Dolibarr, tabs or >> spaces? >> >> Regards, >> >> >> *Marcos García* >> >> marcos...@gmail.com >> >> >> >> >> _______________________________________________ >> Dolibarr-dev mailing >> listDolibarr-dev@nongnu.orghttps://lists.nongnu.org/mailman/listinfo/dolibarr-dev >> >> >> Cordialement, >> -- >> Régis Houssin >> --------------------------------------------------------- >> Cap-Networks >> Cidex 1130 >> 34, route de Gigny >> 71240 MARNAY >> FRANCE >> VoIP: +33 1 83 62 40 03 >> GSM: +33 6 33 02 07 97 >> Web: http://www.cap-networks.com/ >> Email: regis.hous...@cap-networks.com >> >> Dolibarr developer: re...@dolibarr.fr >> Web Portal: http://www.dolibarr.fr/ >> SaaS offers: http://www.dolibox.fr/ >> Shop: http://www.dolistore.com/ >> Development platform: https://doliforge.org/ >> --------------------------------------------------------- >> >> >> _______________________________________________ >> Dolibarr-dev mailing list >> Dolibarr-dev@nongnu.org >> https://lists.nongnu.org/mailman/listinfo/dolibarr-dev >> >> > > > -- > *Raphaël Doursenaud* > 05 35 53 97 13 - 06 68 48 20 10 > rdoursen...@gpcsolutions.fr > > > <http://gpcsolutions.fr> > http://gpcsolutions.fr > Technopole Hélioparc > 2 avenue du Président Pierre Angot > 64053 PAU CEDEX 9 > SARL GPC.solutions au capital de 7 500 € - R.C.S. PAU 528 995 921 > > > _______________________________________________ > Dolibarr-dev mailing > listDolibarr-dev@nongnu.orghttps://lists.nongnu.org/mailman/listinfo/dolibarr-dev > > > Cordialement, > -- > Régis Houssin > --------------------------------------------------------- > Cap-Networks > Cidex 1130 > 34, route de Gigny > 71240 MARNAY > FRANCE > VoIP: +33 1 83 62 40 03 > GSM: +33 6 33 02 07 97 > Web: http://www.cap-networks.com/ > Email: regis.hous...@cap-networks.com > > Dolibarr developer: re...@dolibarr.fr > Web Portal: http://www.dolibarr.fr/ > SaaS offers: http://www.dolibox.fr/ > Shop: http://www.dolistore.com/ > Development platform: https://doliforge.org/ > --------------------------------------------------------- > > > > _______________________________________________ > Dolibarr-dev mailing > listDolibarr-dev@nongnu.orghttps://lists.nongnu.org/mailman/listinfo/dolibarr-dev > > > > -- > Eldy (Laurent Destailleur). > --------------------------------------------------------------- > EMail: e...@destailleur.fr > Web: http://www.destailleur.fr > > Dolibarr (Project leader): http://www.dolibarr.org > To make a donation for Dolibarr project via Paypal: cont...@destailleur.fr > AWStats (Author) : http://awstats.sourceforge.net > To make a donation for AWStats project via Paypal: cont...@destailleur.fr > AWBot (Author) : http://awbot.sourceforge.net > CVSChangeLogBuilder (Author) : http://cvschangelogb.sourceforge.net > > > _______________________________________________ > Dolibarr-dev mailing list > Dolibarr-dev@nongnu.org > https://lists.nongnu.org/mailman/listinfo/dolibarr-dev > >
_______________________________________________ Dolibarr-dev mailing list Dolibarr-dev@nongnu.org https://lists.nongnu.org/mailman/listinfo/dolibarr-dev
