On Wed, Feb 9, 2011 at 8:58 AM, Joachim Berdal Haga <[email protected]> wrote:
>> Is the attached diff an acceptable fix for this?
>
> I would rather the CONFOPTS were done unconditionally. I believe this option
> doesn't take substantial extra time, just writes out the relevant makefiles?

It also does some file copying to be able to run the tests from the
build directory. However, it is rather that the 'runtests' target is
added to TARGETS which will make the Dorsal installation time
increase.

> If it is, then the ENABLE_TESTING flag feels a bit overkill, unless it's a
> general thing (that may in the future enable testing of trilinos, for
> example).

Yes, enabling testing of other packages should be easy to add if desired.

> Just my opinion, of course :)

Thanks for your opinion :-)

Johannes

_______________________________________________
Mailing list: https://launchpad.net/~dorsal
Post to     : [email protected]
Unsubscribe : https://launchpad.net/~dorsal
More help   : https://help.launchpad.net/ListHelp

Reply via email to