On 09/02/11 08:17, Johannes Ring wrote: > On Wed, Feb 9, 2011 at 8:58 AM, Joachim Berdal Haga <[email protected]> wrote: >>> Is the attached diff an acceptable fix for this? >> >> I would rather the CONFOPTS were done unconditionally. I believe this option >> doesn't take substantial extra time, just writes out the relevant makefiles? > > It also does some file copying to be able to run the tests from the > build directory. However, it is rather that the 'runtests' target Iis > added to TARGETS which will make the Dorsal installation time > increase. >
I don't advocate running 'runtests' automatically. I want to be able to run it manually when testing a platform. My take is that it should as simple as adding cppunit to the package lists for systems that have it, and adding -DDOLFIN_ENABLE_TESTING=true to the DOLFIN config. If cppunit it not present, the build system will just ignore it. Garth >> If it is, then the ENABLE_TESTING flag feels a bit overkill, unless it's a >> general thing (that may in the future enable testing of trilinos, for >> example). > > Yes, enabling testing of other packages should be easy to add if desired. > >> Just my opinion, of course :) > > Thanks for your opinion :-) > > Johannes > > _______________________________________________ > Mailing list: https://launchpad.net/~dorsal > Post to : [email protected] > Unsubscribe : https://launchpad.net/~dorsal > More help : https://help.launchpad.net/ListHelp _______________________________________________ Mailing list: https://launchpad.net/~dorsal Post to : [email protected] Unsubscribe : https://launchpad.net/~dorsal More help : https://help.launchpad.net/ListHelp
