So the following happened:
I amended Christians UI patch for making the UI plugin an OSGi module.
http://saros-build.imp.fu-berlin.de/gerrit/#/c/2069/
As you can see in his original patch he already changed the build.xml
file using Ant4Eclipse.
I looked at the Jenkins Gerrit Job and it was already correctly
configured. The build passed and so I submitted the patch.
I did not see any dedicated UI job and so I thought that this will be
added later after the OSGi stuff is added.
The problem is that the IntelliJ and Saros Job already build this UI
plugin. I do not not really understand why this has to be done twice.
Neverless the configuration of these jobs are / were configured to
actually call the old build.xml with the needed parameters.
I already deleted the UI plugin stuff from the Saros build but I am not
going to touch the IntelliJ one.
And BTW it is really a bad idea to build something else in the Saros
Build job because the STF regression jobs simply take
all produced artifacts from the last build (Saros/C and Saros/E) and
deploy them to the Eclipse installations of our both test machines
before running the regression.
And as for the new patch set. It is the same as Christians. I just
removed the UI dependency in Saros/E for now and added some Eclipse
Autoformat stuff and so
regardless of the changes the same build errors would have occurred
unless someone had changed the Jenkins Jobs accordingly before
committing this patch.
BR,
Stefan
On 02.02.2015 16:12, Zieris, Franz wrote:
Hi Stefan,
I do not understand what happened in the builds Saros #1360 and, just
now, Saros_IntelliJ #131.
But I do know that Christian performed some adjustments to some of our
Jenkins jobs some weeks ago.
I also know that Christian started patch #2069 and provided patch sets
1 to 4 between January 24^th and 26^th – and that you created sets 5
and 6 today (leaving Christian as “Author” (!)) and submitted the
patch without further discussion.
I’m not sure about the details, but did you talk with Christian about
this?
For starters, I’m not sure he had any time to take a look whether he
agrees with the code changes you introduced in his name.
So, please, before you blame anyone for not reading some descriptive
(not normative (!) – I know it, because I wrote it) Jenkins job
description and for not drawing some conclusions from this, please
consider playing by the rules first, would you?
Best,
Franz
*From:*Stefan Rossbach [mailto:srossb...@arcor.de]
*Sent:* Monday, February 02, 2015 3:39 PM
*To:* dpp-devel@lists.sourceforge.net
*Subject:* Re: [DPP-Devel] Build failed in Jenkins: Saros #1360
From the Job build description:
Project Saros
This job monitors the |master|
<https://github.com/saros-project/saros/tree/master> branch of the
main Saros repository.
It will build and test both the Saros/Core module
<https://github.com/saros-project/saros/tree/master/de.fu_berlin.inf.dpp.core>
and Saros/Eclipse
<https://github.com/saros-project/saros/tree/master/de.fu_berlin.inf.dpp>
plugin hourly if there are new commits on the |master| branch.
So who was the smart guy that added the plugin stuff to this job ?!
As I am writing these lines I will delete the Ant task.
Please move the UI build to a dedicated job and correct all other
stuff accordingly.
Just because it seems this was the "easiest" solution does not mean
that this is the correct solution.
On 02.02.2015 15:22, jenk...@saros-build.imp.fu-berlin.de
<mailto:jenk...@saros-build.imp.fu-berlin.de> wrote:
See<http://saros-build.imp.fu-berlin.de/jenkins/job/Saros/1360/changes>
<http://saros-build.imp.fu-berlin.de/jenkins/job/Saros/1360/changes>
Changes:
[srossbach] [API] add OSGi manifest to UI library
------------------------------------------
[...truncated 1222 lines...]
[cobertura-report] "assert" ...
[cobertura-report] "assert" ...
[cobertura-report] "assert" ...
[cobertura-report] "assert" ...
[cobertura-report] "assert" ...
[cobertura-report] net.sourceforge.cobertura.javancss.parser.ParseException: Encountered "
"interface" "interface "" at line 46, column 13.
[cobertura-report] Was expecting one of:
[cobertura-report] "assert" ...
[cobertura-report] "enum" ...
[cobertura-report] <IDENTIFIER> ...
[cobertura-report] "enum" ...
[cobertura-report] <IDENTIFIER> ...
[cobertura-report] "assert" ...
[cobertura-report] "assert" ...
[cobertura-report] "enum" ...
[cobertura-report] <IDENTIFIER> ...
[cobertura-report] "assert" ...
[cobertura-report] "assert" ...
[cobertura-report] "enum" ...
[cobertura-report] <IDENTIFIER> ...
[cobertura-report] "assert" ...
[cobertura-report] "assert" ...
[cobertura-report] "assert" ...
[cobertura-report] "assert" ...
[cobertura-report] "assert" ...
[cobertura-report] "assert" ...
[cobertura-report] "assert" ...
[cobertura-report] "assert" ...
[cobertura-report] "assert" ...
[cobertura-report] "assert" ...
[cobertura-report] "assert" ...
[cobertura-report] "assert" ...
[cobertura-report] "enum" ...
[cobertura-report] <IDENTIFIER> ...
[cobertura-report] "assert" ...
[cobertura-report] "assert" ...
[cobertura-report] "enum" ...
[cobertura-report] <IDENTIFIER> ...
[cobertura-report] "assert" ...
[cobertura-report] "assert" ...
[cobertura-report] "enum" ...
[cobertura-report] <IDENTIFIER> ...
[cobertura-report] "assert" ...
[cobertura-report] "assert" ...
[cobertura-report] "assert" ...
[cobertura-report] "assert" ...
[cobertura-report] "assert" ...
[cobertura-report] "assert" ...
[cobertura-report] "assert" ...
[cobertura-report] "assert" ...
[cobertura-report] "assert" ...
[cobertura-report] "assert" ...
[cobertura-report] "assert" ...
[cobertura-report] "assert" ...
[cobertura-report] "assert" ...
[cobertura-report] "assert" ...
[cobertura-report] "assert" ...
[cobertura-report] "assert" ...
[cobertura-report] "assert" ...
[cobertura-report] "assert" ...
[cobertura-report] "assert" ...
[cobertura-report] "assert" ...
[cobertura-report] "assert" ...
[cobertura-report] "enum" ...
[cobertura-report] <IDENTIFIER> ...
[cobertura-report] "assert" ...
[cobertura-report] "assert" ...
[cobertura-report] "enum" ...
[cobertura-report] <IDENTIFIER> ...
[cobertura-report] "assert" ...
[cobertura-report] "assert" ...
[cobertura-report] "assert" ...
[cobertura-report] "assert" ...
[cobertura-report] "assert" ...
[cobertura-report] "assert" ...
[cobertura-report] "assert" ...
[cobertura-report] "assert" ...
[cobertura-report] "assert" ...
[cobertura-report] "assert" ...
[cobertura-report] "assert" ...
[cobertura-report] "assert" ...
[cobertura-report] "assert" ...
[cobertura-report] "enum" ...
[cobertura-report] <IDENTIFIER> ...
[cobertura-report] "assert" ...
[cobertura-report] "assert" ...
[cobertura-report] "enum" ...
[cobertura-report] <IDENTIFIER> ...
[cobertura-report] "assert" ...
[cobertura-report] "assert" ...
[cobertura-report] "enum" ...
[cobertura-report] <IDENTIFIER> ...
[cobertura-report] "assert" ...
[cobertura-report]
[cobertura-report] at
net.sourceforge.cobertura.javancss.parser.JavaParser.generateParseException(JavaParser.java:10296)
[cobertura-report] at
net.sourceforge.cobertura.javancss.parser.JavaParser.jj_consume_token(JavaParser.java:10172)
[cobertura-report] at
net.sourceforge.cobertura.javancss.parser.JavaParser.Name(JavaParser.java:2677)
[cobertura-report] at
net.sourceforge.cobertura.javancss.parser.JavaParser.MarkerAnnotation(JavaParser.java:4699)
[cobertura-report] at
net.sourceforge.cobertura.javancss.parser.JavaParser.Annotation(JavaParser.java:4672)
[cobertura-report] at
net.sourceforge.cobertura.javancss.parser.JavaParser.FieldDeclaration(JavaParser.java:1702)
[cobertura-report] at
net.sourceforge.cobertura.javancss.parser.JavaParser.InterfaceMemberDeclaration(JavaParser.java:1605)
[cobertura-report] at
net.sourceforge.cobertura.javancss.parser.JavaParser.UnmodifiedInterfaceDeclaration(JavaParser.java:1515)
[cobertura-report] at
net.sourceforge.cobertura.javancss.parser.JavaParser.InterfaceDeclaration(JavaParser.java:1316)
[cobertura-report] at
net.sourceforge.cobertura.javancss.parser.JavaParser.TypeDeclaration(JavaParser.java:613)
[cobertura-report] at
net.sourceforge.cobertura.javancss.parser.JavaParser.CompilationUnit(JavaParser.java:353)
[cobertura-report] at
net.sourceforge.cobertura.javancss.parser.JavaParser.parse(JavaParser.java:137)
[cobertura-report] at
net.sourceforge.cobertura.javancss.Javancss._measureSource(Javancss.java:256)
[cobertura-report] at
net.sourceforge.cobertura.javancss.Javancss._measureRoot(Javancss.java:339)
[cobertura-report] at
net.sourceforge.cobertura.javancss.Javancss.<init>(Javancss.java:419)
[cobertura-report] at
net.sourceforge.cobertura.reporting.ComplexityCalculator.getAccumlatedCCNForSource(ComplexityCalculator.java:102)
[cobertura-report] at
net.sourceforge.cobertura.reporting.ComplexityCalculator.getAccumlatedCCNForSingleFile(ComplexityCalculator.java:139)
[cobertura-report] at
net.sourceforge.cobertura.reporting.ComplexityCalculator.getCCNForSourceFileNameInternal(ComplexityCalculator.java:224)
[cobertura-report] at
net.sourceforge.cobertura.reporting.ComplexityCalculator.getCCNForPackageInternal(ComplexityCalculator.java:194)
[cobertura-report] at
net.sourceforge.cobertura.reporting.ComplexityCalculator.getCCNForProject(ComplexityCalculator.java:164)
[cobertura-report] at
net.sourceforge.cobertura.reporting.xml.XMLReport.<init>(XMLReport.java:80)
[cobertura-report] at
net.sourceforge.cobertura.reporting.Main.parseArguments(Main.java:107)
[cobertura-report] at
net.sourceforge.cobertura.reporting.Main.main(Main.java:174)
[cobertura-report] "enum" ...
[cobertura-report] <IDENTIFIER> ...
[cobertura-report] "assert" ...
[cobertura-report] "assert" ...
[cobertura-report] "enum" ...
[cobertura-report] <IDENTIFIER> ...
[cobertura-report] "assert" ...
[cobertura-report] "assert" ...
[cobertura-report] "assert" ...
[cobertura-report] "assert" ...
[cobertura-report] "assert" ...
[cobertura-report] "assert" ...
[cobertura-report] "assert" ...
[cobertura-report] "assert" ...
[cobertura-report] "assert" ...
[cobertura-report] "assert" ...
[cobertura-report] "assert" ...
[cobertura-report] "assert" ...
[cobertura-report] "assert" ...
[cobertura-report] "enum" ...
[cobertura-report] <IDENTIFIER> ...
[cobertura-report] "assert" ...
[cobertura-report] "assert" ...
[cobertura-report] "enum" ...
[cobertura-report] <IDENTIFIER> ...
[cobertura-report] "assert" ...
[cobertura-report] "assert" ...
[cobertura-report] "enum" ...
[cobertura-report] <IDENTIFIER> ...
[cobertura-report] "assert" ...
[cobertura-report]
[cobertura-report]
[cobertura-report] Report time: 5842ms
BUILD SUCCESSFUL
Total time: 1 minute 47 seconds
Statistics:
-------------- Target Results ---------------------
saros-core.clean: 0.044 sec
saros-core.test: 15.259 sec
saros-core.instrument: 33.355 sec
saros-core.build: 49.129 sec
-------------- Task Results -----------------------
saros-core.build.mkdir: 0.000 sec
saros-core.<implicit>.property: 0.001 sec
saros-core.build.echo: 0.002 sec
saros-core.<implicit>.ant4eclipse:targetPlatform: 0.003 sec
saros-core.build.mkdir: 0.004 sec
saros-core.<implicit>.taskdef: 0.006 sec
saros-core.build.scrub-directory: 0.007 sec
saros-core.build.mkdir: 0.008 sec
saros-core.clean.delete: 0.012 sec
saros-core.build.mkdir: 0.013 sec
saros-core.build.copy: 0.016 sec
saros-core.build.sequential: 0.017 sec
saros-core.build.copy: 0.019 sec
saros-core.<implicit>.taskdef: 0.020 sec
saros-core.build.sequential: 0.026 sec
saros-core.<implicit>.macrodef: 0.030 sec
saros-core.build.echo: 0.031 sec
saros-core.build.delete: 0.035 sec
saros-core.build.delete: 0.037 sec
saros-core.build.sequential: 0.038 sec
saros-core.build.copy: 0.043 sec
saros-core.build.sequential: 0.044 sec
saros-core.build.antcontrib:if: 0.045 sec
saros-core.build.sequential: 0.046 sec
saros-core.build.copy: 0.074 sec
saros-core.build.sequential: 0.080 sec
saros-core.build.copy: 0.122 sec
saros-core.<implicit>.taskdef: 0.123 sec
saros-core.build.condition: 0.125 sec
saros-core.build.sequential: 0.146 sec
saros-core.<implicit>.macrodef: 0.173 sec
saros-core.<implicit>.path: 0.234 sec
saros-core.<implicit>.taskdef: 0.259 sec
saros-core.build.jar: 0.347 sec
saros-core.build.sequential: 0.348 sec
saros-core.build.copy: 0.421 sec
saros-core.build.sequential: 0.422 sec
saros-core.build.sequential: 0.444 sec
saros-core.build.sequential: 0.474 sec
saros-core.<implicit>.taskdef: 0.631 sec
saros-core.build.sequential: 0.867 sec
saros-core.build.sequential: 0.868 sec
saros-core.build.copy: 1.131 sec
saros-core.<implicit>.taskdef: 1.163 sec
saros-core.build.sequential: 1.240 sec
saros-core.<implicit>.import: 1.264 sec
saros-core.<implicit>.ant4eclipse:jdtClassPathLibrary: 1.278 sec
saros-core.build.jar: 1.592 sec
saros-core.build.sequential: 2.441 sec
saros-core.build.ant4eclipse:executePluginLibrary: 2.589 sec
saros-core.build.sequential: 2.590 sec
saros-core.build.ant4eclipse:executePluginProject: 3.182 sec
saros-core.<implicit>.taskdef: 3.670 sec
saros-core.build.ant4eclipse:executePluginProject: 6.349 sec
saros-core.test.cobertura-report: 6.870 sec
saros-core.test.junit: 8.387 sec
saros-core.instrument.cobertura-instrument: 33.354 sec
saros-core.build.javac: 35.672 sec
saros-core.build.sequential: 35.674 sec
saros-core.build.ant4eclipse:executeJdtProject: 39.344 sec
saros-core.build.antcontrib:if: 39.583 sec
saros-core.build.sequential: 49.114 sec
saros-core.build.buildPlugin: 49.121 sec
-------------- Totals -----------------------------
Start time: Mon, 2 Feb 2015 15:20:34.614
Stop time: Mon, 2 Feb 2015 15:22:22.062
Total time: 107.448 sec
[File exists] check if file exists [de.fu_berlin.inf.dpp.ui/build.xml]
Run condition [File exists] enabling perform for step [Invoke Ant]
[de.fu_berlin.inf.dpp.ui] $ /var/lib/jenkins/tools/apache-ant-1.9.0/bin/ant
-file build.xml -Djdk.bin=/usr/lib/jvm/jdk1.6.0_45/bin
-Declipse.dir=/var/lib/jenkins/tools/eclipse_3.6.2_x64
Buildfile:<http://saros-build.imp.fu-berlin.de/jenkins/job/Saros/ws/de.fu_berlin.inf.dpp.ui/build.xml>
<http://saros-build.imp.fu-berlin.de/jenkins/job/Saros/ws/de.fu_berlin.inf.dpp.ui/build.xml>
[taskdef] Could not load definitions from resource
net/sf/antcontrib/antcontrib.properties. It could not be found.
[taskdef] Could not load definitions from resource
org/ant4eclipse/antlib.xml. It could not be found.
BUILD FAILED
<http://saros-build.imp.fu-berlin.de/jenkins/job/Saros/ws/de.fu_berlin.inf.dpp.ui/build.xml>
<http://saros-build.imp.fu-berlin.de/jenkins/job/Saros/ws/de.fu_berlin.inf.dpp.ui/build.xml>:12: Cannot
find<http://saros-build.imp.fu-berlin.de/jenkins/job/Saros/ws/de.fu_berlin.inf.dpp.ui/${ant4eclipse.dir}/macros/a4e-pde-macros.xml>
<http://saros-build.imp.fu-berlin.de/jenkins/job/Saros/ws/de.fu_berlin.inf.dpp.ui/$%7bant4eclipse.dir%7d/macros/a4e-pde-macros.xml>
imported from<http://saros-build.imp.fu-berlin.de/jenkins/job/Saros/ws/de.fu_berlin.inf.dpp.ui/build.xml>
<http://saros-build.imp.fu-berlin.de/jenkins/job/Saros/ws/de.fu_berlin.inf.dpp.ui/build.xml>
Total time: 0 seconds
Build step 'Conditional step (single)' marked build as failure
[locks-and-latches] Releasing all the locks
[locks-and-latches] All the locks released
Archiving artifacts
Skipping Cobertura coverage report as build was not UNSTABLE or better ...
Recording test results
Recording fingerprints
------------------------------------------------------------------------------
Dive into the World of Parallel Programming. The Go Parallel Website,
sponsored by Intel and developed in partnership with Slashdot Media, is your
hub for all things parallel software development, from weekly thought
leadership blogs to news, videos, case studies, tutorials and more. Take a
look and join the conversation now.http://goparallel.sourceforge.net/
_______________________________________________
DPP-Devel mailing list
DPP-Devel@lists.sourceforge.net <mailto:DPP-Devel@lists.sourceforge.net>
https://lists.sourceforge.net/lists/listinfo/dpp-devel
------------------------------------------------------------------------------
Dive into the World of Parallel Programming. The Go Parallel Website,
sponsored by Intel and developed in partnership with Slashdot Media, is your
hub for all things parallel software development, from weekly thought
leadership blogs to news, videos, case studies, tutorials and more. Take a
look and join the conversation now. http://goparallel.sourceforge.net/
_______________________________________________
DPP-Devel mailing list
DPP-Devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/dpp-devel
