On 02.02.2015 23:53, Christian Cikryt wrote:
Hi Franz, hi Stefan,
First of all I didn't *just* do anything. I invalidated Stefans
argument against the inclusion of UI (STF job copies all artifacts)
and took the responsibility of fixing the build which Stefan
generously passed on (You are welcome by the way). As Stefan has not
reclaimed responsibility for the Jenkins builds, I see no danger of an
edit war.
The reasons for the inclusion:
* the UI module will not be optional for the build process only in the
execution (feature toggle)
I was talking about deployment (in the test environment) and not about
production
*a separate job would complicated the build process and be even
further away from how a developer builds Saros locally
http://blog.codinghorror.com/the-f5-key-is-not-a-build-process/
* the UI module is not inteded to be build on its own
You just need to compile it against SWT that's all
* the inclusion is easy and *requires no further configuration* of
Jenkins (as it is already done)
As I said everything has its pros and cons
Regarding the IntelliJ build:
As IntelliJ has its own Jenkins job it should be possible to build
IntelliJ without Saros/E. Therefore, it should not rely on any
artifacts from the Saros/E.
So it makes sense to build the core and ui module in each project.
2015-02-02 18:24 GMT+01:00 Stefan Rossbach <srossb...@arcor.de
<mailto:srossb...@arcor.de>>:
Amend the build.xml file in the IntelliJ project as needed. And I
really do not understand why you have not done this as the build
file already builds Saros/C and Saros/I.
Stefan, I don't know if you took a close look at the IntelliJ ANT
script. I looks generated with manual additions. Its multitude of
properties and targets make it very painful to edit. If you are
willing to write the ANT logic to extract jars, use the right paths
and check whether you are running in the Gerrit or Master Job, be my
guest.
The only thing I am willing to do with this script is to replace it
with Maven.
*
*
*Furthermore, I would strongly suggest to copy the separation of
Saros/E and Saros/I to the Gerrit job.* It makes no sense whatsoever
to build Gerrit and master differently.
2015-02-02 20:14 GMT+01:00 Stefan Rossbach <srossb...@arcor.de
<mailto:srossb...@arcor.de>>:
Regardless of the cons and pros on how the jobs are setup the
structure should be unique.
Please elaborate.
If I remember correctly you do not even need to modify the Saros/E
job as long as the dpp.*.ui folder is present during the checkout
as AntJ4 will use this folder when resolving the bundles.
I do not see any problem for building the UI project in a
dedicated job. We did this with Saros Nebula already.
If no explicit ANT call would be required, why is there one for the
core module?
Regards,
Christian
------------------------------------------------------------------------------
Dive into the World of Parallel Programming. The Go Parallel Website,
sponsored by Intel and developed in partnership with Slashdot Media, is your
hub for all things parallel software development, from weekly thought
leadership blogs to news, videos, case studies, tutorials and more. Take a
look and join the conversation now. http://goparallel.sourceforge.net/
_______________________________________________
DPP-Devel mailing list
DPP-Devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/dpp-devel
