Hi Michaela,

IWorkspaceRoot represents an IntelliJ project. Maybe you should do a little refactor in the ShareWithUserAction class to make it clear that you are using modules and projects in IntelliJ but when you have to access the core, you have to "convert" an IntelliJ module to a core project.


So I would stick with the name IntelliJProjectImpl as it is. Maybe add some documentation to the class, that it represents a module internally.

On 20.09.2016 15:57, Michaela Borzechowski wrote:
Hey all,

In IntelliJ and Eclipse a "Project" is a different thing. A project in Eclipse is like a module in IntelliJ. Now there is the class IntelliJProjectImpl, and I was wondering, whether it shouldn't be named IntelliJModuleImpl instead to prevent confusion. The question I have is, whether the class is really only used to model a module. It certainly is used for a module implementation in ShareWithUserAction, but does anyone know if it is used to model a project somewhere?

Thanks
Michaela


------------------------------------------------------------------------------


_______________________________________________
DPP-Devel mailing list
DPP-Devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/dpp-devel

------------------------------------------------------------------------------
_______________________________________________
DPP-Devel mailing list
DPP-Devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/dpp-devel

Reply via email to